Skip to content

Annotate implementations of IPointerTypeSymbol#39203

Merged
sharwell merged 2 commits intodotnet:mainfrom
sharwell:symbol-annotations-18
Jun 27, 2022
Merged

Annotate implementations of IPointerTypeSymbol#39203
sharwell merged 2 commits intodotnet:mainfrom
sharwell:symbol-annotations-18

Conversation

@sharwell
Copy link
Copy Markdown
Contributor

@sharwell sharwell commented Oct 10, 2019

No description provided.

@sharwell sharwell requested review from a team as code owners October 10, 2019 07:06
@jcouv jcouv added the PR For Personal Review Only The PR doesn’t require anyone other than the developer to review it. label Oct 22, 2019
@sharwell sharwell added the Concept-Null Annotations The issue involves annotating an API for nullable reference types label Jan 3, 2020
@sharwell sharwell marked this pull request as draft April 8, 2020 22:29
Base automatically changed from master to main March 3, 2021 23:52
@sharwell sharwell removed Blocked PR For Personal Review Only The PR doesn’t require anyone other than the developer to review it. labels Jun 7, 2022
@sharwell sharwell marked this pull request as ready for review June 7, 2022 20:04
@sharwell sharwell force-pushed the symbol-annotations-18 branch from a1911e6 to 82f6b70 Compare June 7, 2022 20:06
@sharwell
Copy link
Copy Markdown
Contributor Author

sharwell commented Jun 7, 2022

@dotnet/roslyn-compiler this is now updated and ready for review

@sharwell
Copy link
Copy Markdown
Contributor Author

sharwell commented Jun 8, 2022

@dotnet/roslyn-compiler for second review

@dotnet dotnet deleted a comment from azure-pipelines bot Jun 8, 2022
@dotnet dotnet deleted a comment from azure-pipelines bot Jun 8, 2022
jcouv
jcouv approved these changes Jun 8, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 2)

@jcouv jcouv self-assigned this Jun 8, 2022
@sharwell sharwell enabled auto-merge June 8, 2022 16:48
@runfoapp runfoapp bot mentioned this pull request Jun 8, 2022
Open
@sharwell sharwell merged commit 931d6c7 into dotnet:main Jun 27, 2022
@ghost ghost added this to the Next milestone Jun 27, 2022
@sharwell sharwell deleted the symbol-annotations-18 branch June 27, 2022 21:55
@RikkiGibson RikkiGibson modified the milestones: Next, 17.3 P3 Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaredpar jaredpar jaredpar approved these changes

@jcouv jcouv jcouv approved these changes

Assignees

@jcouv jcouv

Labels

Area-Compilers Concept-Null Annotations The issue involves annotating an API for nullable reference types

Projects

None yet

Milestone

17.3 P3

Development

Successfully merging this pull request may close these issues.

5 participants

@sharwell @jaredpar @jcouv @333fred @RikkiGibson