Merged
Conversation
333fred
reviewed
Oct 10, 2019
333fred
reviewed
Oct 10, 2019
Member
|
Done review pass (commit 1) |
RikkiGibson
reviewed
Oct 10, 2019
| { | ||
| #pragma warning disable CS8717 // A member returning a [MaybeNull] value introduces a null value when 'T' is a non-nullable reference type. | ||
| TryDecodeValue(specialType, out T value); | ||
| #pragma warning restore CS8717 // A member returning a [MaybeNull] value introduces a null value when 'T' is a non-nullable reference type. |
Member
There was a problem hiding this comment.
What motivates the usage of pragma warning disable versus !?
Contributor
Author
There was a problem hiding this comment.
Both approaches have merits. This one was chosen as a means to highlight the negative impact this warning is having on the overall NRT development experience.
RikkiGibson
approved these changes
Oct 10, 2019
333fred
approved these changes
Oct 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.