Handle null Display string in FxCopAnalyzersSuggestedActionCallback#39097
Merged
mavasani merged 2 commits intodotnet:masterfrom Oct 8, 2019
Merged
Handle null Display string in FxCopAnalyzersSuggestedActionCallback#39097mavasani merged 2 commits intodotnet:masterfrom
mavasani merged 2 commits intodotnet:masterfrom
Conversation
Fixes dotnet#39092 Also fix VisualStudioAnalyzer to correctly forward the Display value to the underlying analyzer reference.
Contributor
Author
|
@jinujoseph @vatsalyaagrawal Given this change fixes a VS crash, should it target a specific Dev16.4 preview branch earlier then preview targeted by master? |
src/VisualStudio/Core/Def/Implementation/Diagnostics/FxCopAnalyzersSuggestedActionCallback.cs
Outdated
Show resolved
Hide resolved
sharwell
suggested changes
Oct 7, 2019
Contributor
sharwell
left a comment
There was a problem hiding this comment.
Marking request changes for questions
src/VisualStudio/Core/Def/Implementation/ProjectSystem/VisualStudioAnalyzer.cs
Show resolved
Hide resolved
src/VisualStudio/Core/Def/Implementation/Diagnostics/FxCopAnalyzersSuggestedActionCallback.cs
Show resolved
Hide resolved
sharwell
approved these changes
Oct 7, 2019
Contributor
|
lets keep in master for 16.4.p3 |
Contributor
Author
|
@jasonmalinowski Any further feedback? Thanks! |
Contributor
Author
|
Merging this in.. will address any further feedback with a follow-up PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39092
Also fix VisualStudioUnresolvedAnalyzerReference to correctly forward the Display value to the underlying analyzer reference.