Merged
Conversation
Contributor
petrroll
commented
Oct 6, 2019
- Fix for IntroduceVariableCodeRefactoring Crash #38708
- Enabled interleaving of {| and |] in tests (required for the issue regression tests)
- Added general tests for IsUnderselected + machinery.
Contributor
Author
|
Not sure I'm targeting the correct branch, if possible this should get fixed before next 16.4 preview. It also needs to flow to master but I assume that's still automatic (and this branch isn't abandoned). |
miloush
reviewed
Oct 6, 2019
miloush
reviewed
Oct 6, 2019
Contributor
|
This branch is no longer maintained. You can retarget to master. Thanks! |
Contributor
|
@petrroll thanks for the fix, would you pls retarget this to master pls |
Contributor
Author
|
Feedback addressed + cleaned up Tuple usage. |
CyrusNajmabadi
approved these changes
Oct 7, 2019
Contributor
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
Code changes look good :)
Contributor
Author
|
Please review @mavasani |
mavasani
approved these changes
Oct 9, 2019
Contributor
|
Thanks @petrroll! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.