Refactor merging types (dynamic, tuple names, nullability) into a single pass#39069
Merged
gafter merged 2 commits intodotnet:masterfrom Oct 14, 2019
Merged
Refactor merging types (dynamic, tuple names, nullability) into a single pass#39069gafter merged 2 commits intodotnet:masterfrom
gafter merged 2 commits intodotnet:masterfrom
Conversation
Member
Author
|
@cston Could you please have a look at this? #Resolved |
cston
reviewed
Oct 6, 2019
cston
approved these changes
Oct 6, 2019
333fred
reviewed
Oct 7, 2019
jcouv
reviewed
Oct 7, 2019
jcouv
reviewed
Oct 7, 2019
jcouv
reviewed
Oct 7, 2019
src/Compilers/CSharp/Portable/Binder/Semantics/OverloadResolution/MethodTypeInference.cs
Show resolved
Hide resolved
jcouv
reviewed
Oct 7, 2019
src/Compilers/CSharp/Portable/Symbols/Tuples/TupleTypeSymbol.cs
Outdated
Show resolved
Hide resolved
jcouv
approved these changes
Oct 7, 2019
Member
jcouv
left a comment
There was a problem hiding this comment.
LGTM Thanks (iteration 1) with some nits to consider
Member
Author
|
@333fred I think I've responded to all of your comments. Do you have any others? |
333fred
approved these changes
Oct 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30669