Better array pattern index codegen#38988
Merged
agocke merged 3 commits intodotnet:masterfrom Oct 8, 2019
Merged
Conversation
60c1add to
8fbd05a
Compare
alrz
reviewed
Oct 3, 2019
| { | ||
| // Code size 17 (0x11) | ||
| .maxstack 3 | ||
| .locals init (int V_0) |
Member
Author
There was a problem hiding this comment.
It looks like it's only used for a conversion below in the stloc/ldloc pair. Probably unnecessary, but the JIT gets rid of that, so it's no different in performance. Not sure why codegen makes the local but it may be possible to improve.
cston
reviewed
Oct 7, 2019
src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_IndexerAccess.cs
Outdated
Show resolved
Hide resolved
cston
approved these changes
Oct 7, 2019
This was referenced Feb 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38942