Fix refout internal attribute constructor fatal exception#38873
Draft
lukaszunity wants to merge 2 commits intodotnet:mainfrom
Draft
Fix refout internal attribute constructor fatal exception#38873lukaszunity wants to merge 2 commits intodotnet:mainfrom
lukaszunity wants to merge 2 commits intodotnet:mainfrom
Conversation
Verifies that an reference assembly with an internal attribute constructor is emitted without errors.
Fixes issue with fatal KeyNotFoundException exception being thrown when emitting a reference assembly that uses a custom attribute with an internal constructor.
|
|
Member
|
Hi @lukaszunity, it looks like there are test failures in this PR. Please ping @dotnet/roslyn-compiler when they are fixed and we will review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue with "FATAL UNHANDLED EXCEPTION" being thrown by Roslyn when using /refout and compiling C# code that uses a custom attribute with an
internalconstructor. The issue below contains more details.Fixes issue #38444