Skip to content

Ensure synthesized closure method is static for static local function#38147

Merged
cston merged 2 commits intodotnet:masterfrom
cston:38143
Oct 17, 2019
Merged

Ensure synthesized closure method is static for static local function#38147
cston merged 2 commits intodotnet:masterfrom
cston:38143

Conversation

@cston
Copy link
Contributor

@cston cston commented Aug 20, 2019

Fixes #38143

@JoeRobich JoeRobich closed this Aug 29, 2019
@JoeRobich
Copy link
Member

JoeRobich commented Aug 29, 2019

Sorry, I should have retargeted these PRs before removing that branch. Repushed branch and will reopen and retarget. #Closed

@JoeRobich JoeRobich reopened this Aug 29, 2019
@JoeRobich JoeRobich changed the base branch from release/dev16.4-preview1 to master August 29, 2019 23:20
@cston cston force-pushed the 38143 branch 3 times, most recently from 1e7c128 to 55c7cb6 Compare October 15, 2019 20:22
@cston cston marked this pull request as ready for review October 16, 2019 15:16
@cston cston requested a review from a team as a code owner October 16, 2019 15:16
@cston cston added this to the 16.4.P2 milestone Oct 16, 2019
Copy link
Member

@gafter gafter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@RikkiGibson RikkiGibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cston cston modified the milestones: 16.4.P2, 16.4.P3 Oct 16, 2019
@cston cston merged commit e445f1e into dotnet:master Oct 17, 2019
@cston cston deleted the 38143 branch October 17, 2019 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

static Local Functions are not being emitted as static

5 participants