Skip to content

Enable EnC and PDB tests on Core#37750

Merged
tmat merged 13 commits intodotnet:masterfrom
tmat:EncTestsCore
Sep 10, 2019
Merged

Enable EnC and PDB tests on Core#37750
tmat merged 13 commits intodotnet:masterfrom
tmat:EncTestsCore

Conversation

@tmat
Copy link
Copy Markdown
Member

@tmat tmat commented Aug 6, 2019 •
edited
Loading

Fixes #37137
Fixes #37047
Fixes #33564 for PDBs

@tmat tmat requested a review from a team as a code owner August 6, 2019 01:38
jaredpar
jaredpar approved these changes Aug 6, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@jaredpar jaredpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tmat tmat changed the title Enable EnC tests on Core Enable EnC and PDB tests on Core Aug 7, 2019
@tmat tmat requested a review from a team as a code owner August 8, 2019 02:16
@tmat tmat mentioned this pull request Aug 8, 2019
Closed
@tmat
Copy link
Copy Markdown
Member Author

tmat commented Aug 9, 2019

@jaredpar Not sure why tests started failing on Mono with this error:

System.Exception : Error getting signatures Base.Method: Explicit assembly load didn't update the proper cache: 'System.ValueTuple' (754a0d2f-8ae6-468c-90a1-fd885ad140fa)

The PR is otherwise ready for merge.

@tmat tmat merged commit 798885c into dotnet:master Sep 10, 2019
@tmat tmat deleted the EncTestsCore branch September 10, 2019 00:04
@lambdageek lambdageek mentioned this pull request Jan 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment