Fix couple of unit tests that started failing after #36566 merged fro…#36790
Conversation
…ed from master to release\dev16.3-preview1 Not sure why the unit test failures were not caught by the merge PR, as these tests are failing consistently in CI for PRs targeting release\dev16.3-preview1
| @@ -164,19 +164,7 @@ public async Task ConfigureEditorconfig_MaintainExistingEntry_None() | |||
| </Project> | |||
| </Workspace>"; | |||
|
|
|||
There was a problem hiding this comment.
@jasonmalinowski Now that #36566 is merged in, none in editorconfig is correctly treated as a suppression by the compiler, so this test failure is expected. Not sure how merge from master into release\dev16.3-preview did not see these failures in CI.
There was a problem hiding this comment.
Oh unless this is another case where we had two CIs from the same source branch and it got misreported.
There was a problem hiding this comment.
Which merge PR was the one that broke it as best you can tell?
There was a problem hiding this comment.
Yeah, this is that bug again. Was going to wait until next week since I knew @sharwell had previously reached out but clearly this is more urgent.
RikkiGibson
left a comment
There was a problem hiding this comment.
Please merge as soon as CI lets us
…m master to release\dev16.3-preview1
Not sure why the unit test failures were not caught by the merge PR, as these tests are failing consistently in CI for PRs targeting release\dev16.3-preview1