Handle lazy loading of analyzer command handlers#36740
Merged
mavasani merged 2 commits intodotnet:masterfrom Jun 25, 2019
Merged
Handle lazy loading of analyzer command handlers#36740mavasani merged 2 commits intodotnet:masterfrom
mavasani merged 2 commits intodotnet:masterfrom
Conversation
jinujoseph
approved these changes
Jun 25, 2019
jasonmalinowski
approved these changes
Jun 25, 2019
Member
|
@mavasani Any idea what broke this? Any chance we can get a test somehow without too much work? |
Contributor
Author
Looking at the code, my guess was this is due to our async load of components after solution has loaded: http://source.roslyn.io/#Microsoft.VisualStudio.LanguageServices/Implementation/LanguageService/AbstractPackage.cs,0e9498e29adafc1c,references
I assumed we would not have any tests for this, but let me look around for a bit :) |
…prior to the fix.
Contributor
Author
@jasonmalinowski Added unit test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36304