Merged
Conversation
The resource in question has an ID that is 414 characters long. This is apparently too long for some of the tools used by the loc team, blocking parts of their processes. The exact failure mechanism is not well understood but in order to avoid problems with the final loc pass for 16.2 I'm just going to go ahead and shorten it. Unfortunately no one knows how long resource IDs can be before they cause problems. At the suggestion of the loc team I'm shortening this one by 50 characters which lines up nicely with a natural break in the ID.
jasonmalinowski
approved these changes
Jun 14, 2019
Contributor
Author
|
@jinujoseph This is ready for your approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The resource in question has an ID that is 414 characters long. This is
apparently too long for some of the tools used by the loc team, blocking
parts of their processes. The exact failure mechanism is not well
understood but in order to avoid problems with the final loc pass for
16.2 I'm just going to go ahead and shorten it.
Unfortunately no one knows how long resource IDs can be before they
cause problems. At the suggestion of the loc team I'm shortening this
one by 50 characters which lines up nicely with a natural break in the ID.