WIP: Get IVsHierarchy from AbstractProject if not available via IVsSolution by tmat · Pull Request #36461 · dotnet/roslyn

tmat · 2019-06-14T18:29:00Z

Fixes https://dev.azure.com/devdiv/DevDiv/_workitems/edit/915798

amcasey

Seems to fix TS move-to-file. Thanks!

tmat · 2019-06-14T19:00:47Z

jasonmalinowski · 2019-06-14T19:06:52Z

src/VisualStudio/Core/Def/Implementation/ProjectSystem/VisualStudioWorkspaceImpl.cs

+            }
+
+#pragma warning disable CS0618 // Type or member is obsolete
+            var project = _projectTracker.GetProject(projectId);


What's the plan for this once we finally move TypeScript off of this shim? Can we add a comment describing what that plan would be here?

(I understand this is a useful tactical fix which is good for now.)

jasonmalinowski

Fine as a tactical fix to unblock but we'll need a better plan.

tmat · 2019-06-14T19:52:07Z

Yeah, I don't have a plan yet

sharwell · 2019-06-17T19:09:44Z

Integration tests failure is probably a true failure. Here's the stack for one of the crashes:

Event Time (UTC): 6/14/2019 9:35:09 PM
Event ID: 1025
Data: Application: devenv.exe
Framework Version: v4.0.30319
Description: The application requested process termination through System.Environment.FailFast(string message).
Message: System.NullReferenceException: Object reference not set to an instance of an object.
   at Microsoft.VisualStudio.LanguageServices.Implementation.ProjectSystem.VisualStudioWorkspaceImpl.TryGetHierarchy(ProjectId projectId, IVsHierarchy& hierarchy)
   at Microsoft.VisualStudio.LanguageServices.Implementation.ProjectSystem.VisualStudioWorkspaceImpl.IsCPSProject(Project project)
   at Microsoft.VisualStudio.LanguageServices.Implementation.DesignerAttribute.DesignerAttributeIncrementalAnalyzer.<IsCpsProjectAsync>d__13.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.ConfiguredTaskAwaitable`1.ConfiguredTaskAwaiter.GetResult()
   at Microsoft.VisualStudio.LanguageServices.Implementation.DesignerAttribute.DesignerAttributeIncrementalAnalyzer.<AnalyzeDocumentAsync>d__9.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.ConfiguredTaskAwaitable.ConfiguredTaskAwaiter.GetResult()
   at Microsoft.CodeAnalysis.SolutionCrawler.SolutionCrawlerRegistrationService.WorkCoordinator.IncrementalAnalyzerProcessor.<>c__DisplayClass32_1`1.<<RunAnalyzersAsync>b__0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.ConfiguredTaskAwaitable`1.ConfiguredTaskAwaiter.GetResult()
   at Microsoft.CodeAnalysis.SolutionCrawler.SolutionCrawlerRegistrationService.WorkCoordinator.IncrementalAnalyzerProcessor.<GetOrDefaultAsync>d__35`2.MoveNext()
Stack:
   at System.Environment.FailFast(System.String, System.Exception)
   at Microsoft.CodeAnalysis.FailFast.OnFatalException(System.Exception)
   at Microsoft.CodeAnalysis.ErrorReporting.FatalError.Report(System.Exception, System.Action`1<System.Exception>)
   at Microsoft.CodeAnalysis.ErrorReporting.FatalError.Report(System.Exception)
   at Microsoft.CodeAnalysis.SolutionCrawler.SolutionCrawlerRegistrationService+WorkCoordinator+IncrementalAnalyzerProcessor+<GetOrDefaultAsync>d__35`2[[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089],[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].MoveNext()
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(System.Threading.Tasks.Task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(System.Threading.Tasks.Task)
   at System.Runtime.CompilerServices.ConfiguredTaskAwaitable`1+ConfiguredTaskAwaiter[[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].GetResult()
   at Microsoft.CodeAnalysis.SolutionCrawler.SolutionCrawlerRegistrationService+WorkCoordinator+IncrementalAnalyzerProcessor+<GetOrDefaultAsync>d__35`2[[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089],[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].MoveNext()
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore+MoveNextRunner.InvokeMoveNext(System.Object)
   at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
   at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore+MoveNextRunner.Run()
   at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(System.Action, Boolean, System.Threading.Tasks.Task ByRef)
   at System.Threading.Tasks.Task.FinishContinuations()
   at System.Threading.Tasks.Task.FinishStageThree()
   at System.Threading.Tasks.Task.FinishStageTwo()
   at System.Threading.Tasks.Task.Finish(Boolean)
   at System.Threading.Tasks.Task`1[[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].TrySetException(System.Object)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1[[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].SetException(System.Exception)
   at Microsoft.CodeAnalysis.SolutionCrawler.SolutionCrawlerRegistrationService+WorkCoordinator+IncrementalAnalyzerProcessor+<>c__DisplayClass32_1`1+<<RunAnalyzersAsync>b__0>d[[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].MoveNext()
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore+MoveNextRunner.InvokeMoveNext(System.Object)
   at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
   at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore+MoveNextRunner.Run()
   at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(System.Action, Boolean, System.Threading.Tasks.Task ByRef)
   at System.Threading.Tasks.Task.FinishContinuations()
   at System.Threading.Tasks.Task.FinishStageThree()
   at System.Threading.Tasks.Task.FinishStageTwo()
   at System.Threading.Tasks.Task.Finish(Boolean)
   at System.Threading.Tasks.Task`1[[System.Threading.Tasks.VoidTaskResult, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].TrySetException(System.Object)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1[[System.Threading.Tasks.VoidTaskResult, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].SetException(System.Exception)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder.SetException(System.Exception)
   at Microsoft.VisualStudio.LanguageServices.Implementation.DesignerAttribute.DesignerAttributeIncrementalAnalyzer+<AnalyzeDocumentAsync>d__9.MoveNext()
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore+MoveNextRunner.InvokeMoveNext(System.Object)
   at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
   at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore+MoveNextRunner.Run()
   at System.Threading.Tasks.AwaitTaskContinuation.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
   at System.Threading.ThreadPoolWorkQueue.Dispatch()
   at System.Threading._ThreadPoolWaitCallback.PerformWaitCallback()

…oject creation

tmat · 2019-06-17T20:34:32Z

@sharwell Thanks! I addressed the crash.

tmat · 2019-06-17T20:34:53Z

@jasonmalinowski PTAL again. Now includes the workaround for Project GUID initialization.

tmat · 2019-06-18T00:00:40Z

We decided to revert the original PR as it uncovered a bug in project system that needs to be fixed first.

jasonmalinowski · 2019-06-20T01:48:19Z

@tmat Should this be ignored or closed then?

amcasey · 2019-06-26T18:14:29Z

@tmat What's the latest on this? Did some version of it get merged and, ideally, inserted?

amcasey · 2019-06-26T18:15:06Z

cc @jessetrinity

tmat · 2019-06-26T20:22:00Z

We had to roll the change back because of a Project System bug. Once the bug is fixed we will try again.

Get IVsHierarchy from AbstractProject if not available via IVsSolution

54ef592

tmat requested a review from a team as a code owner June 14, 2019 18:29

tmat changed the base branch from master to release/dev16.2-preview3 June 14, 2019 18:29

amcasey approved these changes Jun 14, 2019

View reviewed changes

jinujoseph added Area-IDE Needs Shiproom Approval labels Jun 14, 2019

jinujoseph added this to the 16.2 milestone Jun 14, 2019

jasonmalinowski reviewed Jun 14, 2019

View reviewed changes

jasonmalinowski approved these changes Jun 14, 2019

View reviewed changes

tmat changed the base branch from release/dev16.2-preview3 to master June 14, 2019 20:54

jinujoseph added Approved to merge and removed Needs Shiproom Approval labels Jun 14, 2019

jinujoseph modified the milestones: 16.2, 16.2.P4 Jun 14, 2019

Initialize project tracker

9366f5c

tmat mentioned this pull request Jun 17, 2019

Revert 35746 #36512

Merged

Do not fail if Project GUID is not available at the time of legacy pr…

d2f5c3a

…oject creation

tmat force-pushed the FixAddDocument branch from 756d9c2 to d2f5c3a Compare June 17, 2019 20:32

tmat modified the milestones: 16.2.P4, 16.3 Jun 18, 2019

tmat changed the title ~~Get IVsHierarchy from AbstractProject if not available via IVsSolution~~ WIP: Get IVsHierarchy from AbstractProject if not available via IVsSolution Jun 18, 2019

tmat mentioned this pull request Jun 18, 2019

IVsHierarchy Project GUID might not be initialized at the time AbstractLegacyproject reads it #36516

Closed

jinujoseph removed the Approved to merge label Jun 20, 2019

tmat closed this Jun 20, 2019

Conversation

tmat commented Jun 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amcasey left a comment

Choose a reason for hiding this comment

Uh oh!

tmat commented Jun 14, 2019

Uh oh!

jasonmalinowski Jun 14, 2019

Choose a reason for hiding this comment

Uh oh!

jasonmalinowski Jun 14, 2019

Choose a reason for hiding this comment

Uh oh!

jasonmalinowski left a comment

Choose a reason for hiding this comment

Uh oh!

tmat commented Jun 14, 2019

Uh oh!

sharwell commented Jun 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tmat commented Jun 17, 2019

Uh oh!

tmat commented Jun 17, 2019

Uh oh!

tmat commented Jun 18, 2019

Uh oh!

jasonmalinowski commented Jun 20, 2019

Uh oh!

amcasey commented Jun 26, 2019

Uh oh!

amcasey commented Jun 26, 2019

Uh oh!

tmat commented Jun 26, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tmat commented Jun 14, 2019 •

edited

Loading

sharwell commented Jun 17, 2019 •

edited

Loading