Loc the Naming Specification Symbol Kinds#36433
Merged
jinujoseph merged 3 commits intodotnet:masterfrom Jun 14, 2019
Merged
Conversation
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/824308/ In Naming Styles, we previously hadn't been localizing the "Symbol Kinds" list, along with the other two lists there (Accessibilities and Modifiers). We've decided to loc just the "Symbol Kinds" list because the other two lists are exclusively language keywords.
Contributor
Author
|
@dotnet/roslyn-ide @tmeschter for review (Tom, can you take a quick look at the description text for these and let me know if I should adjust?) |
sharwell
approved these changes
Jun 13, 2019
tmeschter
reviewed
Jun 13, 2019
tmeschter
reviewed
Jun 13, 2019
Contributor
Author
|
@tmeschter Responded to your feedback. Can you please re-review? |
tmeschter
approved these changes
Jun 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/824308/
In Naming Styles, we previously hadn't been localizing the "Symbol Kinds" list, along with the other two lists there (Accessibilities and Modifiers). We've decided to loc just the "Symbol Kinds" list because the other two lists are exclusively language keywords.