Merged
Conversation
Contributor
Author
|
tagging @dotnet/roslyn-ide @jinujoseph |
sharwell
approved these changes
Jun 13, 2019
Contributor
|
📝 This hash is not used for security-related purpose. Any hash code with a negligible risk of unintentional collision would be acceptable. For this purpose, SHA1 and SHA256 are equivalent. We are choosing to use the latter so this body of code stops appearing as a line item in internal security reviews. The main concern in this space was performance. I completed an evaluation of SHA256 at scale (Roslyn.sln) with @heejaechang a few months ago and determined that, after we made a small fix that's already in place (#33496), the performance difference between the two would not be observable even by the most discerning users. |
Contributor
|
cc @tmat for review as well |
tmat
approved these changes
Jun 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it is required for d16.2
fix - https://devdiv.visualstudio.com/DevDiv/_workitems/edit/788328