Skip to content

move to sha256#36399

Merged
heejaechang merged 1 commit intodotnet:masterfrom
heejaechang:sha2
Jun 13, 2019
Merged

move to sha256#36399
heejaechang merged 1 commit intodotnet:masterfrom
heejaechang:sha2

Conversation

@heejaechang
Copy link
Copy Markdown
Contributor

@heejaechang heejaechang requested a review from a team as a code owner June 13, 2019 07:35
@heejaechang
Copy link
Copy Markdown
Contributor Author

tagging @dotnet/roslyn-ide @jinujoseph

@sharwell
Copy link
Copy Markdown
Contributor

sharwell commented Jun 13, 2019

📝 This hash is not used for security-related purpose. Any hash code with a negligible risk of unintentional collision would be acceptable. For this purpose, SHA1 and SHA256 are equivalent. We are choosing to use the latter so this body of code stops appearing as a line item in internal security reviews.

The main concern in this space was performance. I completed an evaluation of SHA256 at scale (Roslyn.sln) with @heejaechang a few months ago and determined that, after we made a small fix that's already in place (#33496), the performance difference between the two would not be observable even by the most discerning users.

@sharwell sharwell changed the title move to sha2 move to sha256 Jun 13, 2019
@jinujoseph
Copy link
Copy Markdown
Contributor

jinujoseph commented Jun 13, 2019

cc @tmat for review as well

@heejaechang heejaechang merged commit d5b8d64 into dotnet:master Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants