Skip to content

ISymbol - added missing tag#36386

Merged
jcouv merged 2 commits intodotnet:masterfrom
mairaw:isymbol
Jun 13, 2019
Merged

ISymbol - added missing tag#36386
jcouv merged 2 commits intodotnet:masterfrom
mairaw:isymbol

Conversation

@mairaw
Copy link
Copy Markdown
Contributor

@mairaw mairaw commented Jun 12, 2019

Fixes dotnet/docs#12737

Minor style guide fixes as well

@mairaw mairaw requested a review from a team as a code owner June 12, 2019 23:41
@jcouv jcouv added this to the 16.2.P4 milestone Jun 12, 2019
Copy link
Copy Markdown
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 2)

Copy link
Copy Markdown
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (iteration 2)

@jcouv jcouv self-assigned this Jun 13, 2019
@333fred
Copy link
Copy Markdown
Member

333fred commented Jun 13, 2019

@jcouv what are you waiting on to merge this?

@jcouv jcouv merged commit 94fc519 into dotnet:master Jun 13, 2019
@jcouv
Copy link
Copy Markdown
Member

jcouv commented Jun 13, 2019

Nothing. CI wasn't green last night and I didn't open this PR today ;-)
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing list elements

4 participants