Fix #33560 Handle equal tokens where Text is not available.#36380
Merged
sharwell merged 4 commits intodotnet:masterfrom Jun 14, 2019
Merged
Fix #33560 Handle equal tokens where Text is not available.#36380sharwell merged 4 commits intodotnet:masterfrom
sharwell merged 4 commits intodotnet:masterfrom
Conversation
|
|
src/Workspaces/CSharp/Portable/Utilities/FormattingRangeHelper.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Jun 13, 2019
Contributor
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
Approve
Submit feedback approving these changes.
Member
|
@jinujoseph @vatsalyaagrawal for approval |
sharwell
reviewed
Jun 13, 2019
genlu
reviewed
Jun 13, 2019
src/Workspaces/CSharp/Portable/Utilities/FormattingRangeHelper.cs
Outdated
Show resolved
Hide resolved
Address formatting style suggestion. Co-Authored-By: Gen Lu <genlu@users.noreply.github.com>
Contributor
|
Thank you @Andrew-Hanlon ! :) |
sharwell
approved these changes
Jun 14, 2019
Contributor
|
@jinujoseph for approval |
Contributor
|
Thank you @Andrew-Hanlon ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33560
I updated the helper method
AreTwoTokensOnSameLineto exit early when the provided tokens are equal. This prevents an exception from being thrown when equal tokens are provided and theSyntaxTreeis null or theSyntaxTree.TryGetText()call fails. I added unit tests to cover basic regressions as well as the erroneous case above.