Re-enable MSBuildWorkspaceTests.TestEditorConfigDiscovery#36345
Merged
jasonmalinowski merged 3 commits intodotnet:masterfrom Jun 15, 2019
Merged
Re-enable MSBuildWorkspaceTests.TestEditorConfigDiscovery#36345jasonmalinowski merged 3 commits intodotnet:masterfrom
jasonmalinowski merged 3 commits intodotnet:masterfrom
Conversation
Member
Author
|
We believe the machines are now updated so the hope is this should work. |
e580de1 to
9278bda
Compare
jasonmalinowski
commented
Jun 13, 2019
Member
Author
There was a problem hiding this comment.
I pulled this out to isolate the "have we already checked" cache since it was getting a bit screwy with all of the static bits. Unfortunately this made the diff icky.
Member
Author
|
Tagging @jinujoseph for M2 approval although this is a test-only change. |
Contributor
|
pre-approved |
JoeRobich
approved these changes
Jun 14, 2019
We have need for certain tests to only run on 16.2 or higher; so this adds support to specify that.
Our integration test framework intentionally writes an .editorconfig into the root of %TEMP% so we don't have integration tests depending on an .editorconfig somewhere else on the machine. This causes the unit tests running to discover a second file. Filter that one out.
2d9706f to
866f6e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Besides unskipping the test, we also had to update our test harness. We have to locate an MSBuild on the machine which is suitable for our use, once we found one we just used that. On our machines we have both 15.9 and 16.2 (as of this writing), but we always picked 15.9. Now, we look for the highest version and will add binding redirects to that one; we can also filter tests to a specific minimum version if necessary. It's critical we always find the highest version when first setting up -- we have to add binding logic to make sure we load that; if we loaded a lower version for a test that had a lower minimum version, we wouldn't be able to run another test later.