Add back constructor to ProjectExternalErrorReporter#36328
Merged
JoeRobich merged 2 commits intorelease/dev16.2-preview3from Jun 11, 2019
Merged
Add back constructor to ProjectExternalErrorReporter#36328JoeRobich merged 2 commits intorelease/dev16.2-preview3from
JoeRobich merged 2 commits intorelease/dev16.2-preview3from
Conversation
333fred
approved these changes
Jun 11, 2019
jinujoseph
approved these changes
Jun 11, 2019
tmat
approved these changes
Jun 11, 2019
Member
tmat
left a comment
There was a problem hiding this comment.
Could you please file an issue to follow up and update F#?
jasonmalinowski
approved these changes
Jun 11, 2019
Member
jasonmalinowski
left a comment
There was a problem hiding this comment.
Code looks fine but I'm not entirely familiar with the refactoring that was done so I can't speak to correctness, but if it works then that's enough for me. 😄
src/VisualStudio/Core/Def/Implementation/TaskList/ProjectExternalErrorReporter.cs
Outdated
Show resolved
Hide resolved
Member
Author
@tmat Opened dotnet/fsharp#6981 to track its removal |
9c14708 to
a90250f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This constructor is still used by F#.