Skip to content

Update 'Use pattern matching' to recognize other null checks#36326

Merged
sharwell merged 3 commits intodotnet:masterfrom
sharwell:pattern-object
Jun 12, 2019
Merged

Update 'Use pattern matching' to recognize other null checks#36326
sharwell merged 3 commits intodotnet:masterfrom
sharwell:pattern-object

Conversation

@sharwell
Copy link
Copy Markdown
Contributor

@sharwell sharwell commented Jun 11, 2019

  • Recognize is object as a non-null check
  • Recognize is null as a null check

Fixes #36315

@sharwell sharwell requested a review from a team as a code owner June 11, 2019 17:26
CyrusNajmabadi
CyrusNajmabadi approved these changes Jun 11, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve
Submit feedback approving these changes.

@jinujoseph jinujoseph added this to the 16.2 milestone Jun 12, 2019
@sharwell sharwell merged commit 5f52810 into dotnet:master Jun 12, 2019
@sharwell sharwell deleted the pattern-object branch June 12, 2019 13:11
@sharwell sharwell modified the milestones: 16.2, 16.2.P4 Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

@mavasani mavasani mavasani approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Approved to merge Area-IDE

Projects

None yet

Milestone

16.2.P4

Development

Successfully merging this pull request may close these issues.

'Use pattern matching' doesn't recognize 'is object' as a non-null check

4 participants

@sharwell @CyrusNajmabadi @mavasani @jinujoseph