Propogate nullable type information for EncapsulateFieldService #36286
Merged
ryzngard merged 3 commits intodotnet:masterfrom Jun 13, 2019
Merged
Propogate nullable type information for EncapsulateFieldService #36286ryzngard merged 3 commits intodotnet:masterfrom
ryzngard merged 3 commits intodotnet:masterfrom
Conversation
ryzngard
commented
Jun 10, 2019
src/Features/Core/Portable/EncapsulateField/AbstractEncapsulateFieldService.cs
Outdated
Show resolved
Hide resolved
chborl
reviewed
Jun 11, 2019
src/Features/Core/Portable/EncapsulateField/AbstractEncapsulateFieldService.cs
Outdated
Show resolved
Hide resolved
src/Features/Core/Portable/EncapsulateField/AbstractEncapsulateFieldService.cs
Outdated
Show resolved
Hide resolved
jasonmalinowski
approved these changes
Jun 12, 2019
Member
|
Tagging @jinujoseph for delegated M2 approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30320
Make sure to use
WithNullabilitywhen passing the type.Add a test for
string?property generation