Reduce dependencies#36283
Merged
JoeRobich merged 1 commit intodotnet:release/dev16.2-preview2from Jun 14, 2019
Merged
Conversation
src/Features/Core/Portable/Microsoft.CodeAnalysis.Features.csproj
Outdated
Show resolved
Hide resolved
src/VisualStudio/Core/Def/Microsoft.VisualStudio.LanguageServices.csproj
Outdated
Show resolved
Hide resolved
a4d00eb to
cd90555
Compare
Member
Author
|
@jasonmalinowski Can you give this another look? |
Member
Author
|
@tmat please take a look |
jasonmalinowski
approved these changes
Jun 14, 2019
Member
jasonmalinowski
left a comment
There was a problem hiding this comment.
Looks good to me, and thanks for the comment!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few issues were found when validating NuGet packages for the 16.2 preview2 release.
Also I’m getting this error on upgrade that Microsoft.CodeAnalysis.FlowAnalysis.Utilities is missing (from Microsoft.CodeAnalysis.Features) as well.We will publish the required packages to NuGet and unlist.@tmat and @jasonmalinowski please take a look