Handle missing private metadata from reference assemblies#36267
Merged
sharwell merged 1 commit intodotnet:masterfrom Jun 10, 2019
Merged
Handle missing private metadata from reference assemblies#36267sharwell merged 1 commit intodotnet:masterfrom
sharwell merged 1 commit intodotnet:masterfrom
Conversation
Some reference assemblies omit information about private fields. To avoid treating structures in these assemblies as immutable, we only consider types immutable if they contain information about one or more private fields. This is a workaround for issues like dotnet/standard#678.
mavasani
reviewed
Jun 10, 2019
| type = type.GetTypeArguments()[0]; | ||
| } | ||
|
|
||
| switch (type.SpecialType) |
Contributor
There was a problem hiding this comment.
Is it possible to add a unit test?
Contributor
Author
There was a problem hiding this comment.
Not in any straightforward manner. We will be able to once dotnet/roslyn-sdk#329 is available.
Contributor
Author
There was a problem hiding this comment.
The behavior anomaly is an artifact of the reference assembly in NETStandard.Library 2.0.0 and does not occur with the implementation or runtime assemblies. It also doesn't occur with reference assemblies produced by the current C# compiler because the underlying concern was already addressed.
genlu
approved these changes
Jun 10, 2019
mavasani
approved these changes
Jun 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some reference assemblies omit information about private fields. To avoid treating structures in these assemblies as immutable, we only consider types immutable if they contain information about one or more
private fields.
This is a workaround for issues like dotnet/standard#678.