Skip to content

Pass arguments to StreamJsonRpc as arrays#36262

Merged
sharwell merged 1 commit intodotnet:masterfrom
sharwell:rpc-arrays
Jun 10, 2019
Merged

Pass arguments to StreamJsonRpc as arrays#36262
sharwell merged 1 commit intodotnet:masterfrom
sharwell:rpc-arrays

Conversation

@sharwell
Copy link
Copy Markdown
Contributor

@sharwell sharwell commented Jun 8, 2019

Works around microsoft/vs-streamjsonrpc#272 so our integration tests don't throw exceptions when we run them on machines with 16.1 installed.

@sharwell sharwell requested review from a team as code owners June 8, 2019 20:24
Copy link
Copy Markdown
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiler change (added extension method) LGTM. Thanks (iteration 1)

Copy link
Copy Markdown
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (iteration 1)

@sharwell sharwell merged commit 797e163 into dotnet:master Jun 10, 2019
@sharwell sharwell deleted the rpc-arrays branch June 10, 2019 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants