Filter out missing import fixes that would add references#36251
Merged
JoeRobich merged 2 commits intodotnet:masterfrom Jun 11, 2019
Merged
Filter out missing import fixes that would add references#36251JoeRobich merged 2 commits intodotnet:masterfrom
JoeRobich merged 2 commits intodotnet:masterfrom
Conversation
bb79480 to
6697d74
Compare
.../Core/Portable/CodeRefactorings/AddMissingImports/AbstractAddMissingImportsFeatureService.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
@sharwell please take a look |
sharwell
approved these changes
Jun 11, 2019
Member
Author
|
@vatsalyaagrawal for approval |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the user to choose when they want to add and which references they want to add to their project.
Resolves #34398, since the error is triggered by a foreground assertion when adding Framework assembly references.