Wait for project system before waiting for workspace#36245
Merged
sharwell merged 1 commit intodotnet:masterfrom Jun 7, 2019
Merged
Wait for project system before waiting for workspace#36245sharwell merged 1 commit intodotnet:masterfrom
sharwell merged 1 commit intodotnet:masterfrom
Conversation
JoeRobich
approved these changes
Jun 7, 2019
Contributor
Author
|
Merging since the failures here were not related to the specific addition. |
| { | ||
| if (waitForWorkspaceFirst || featuresToWaitFor == FeatureAttribute.Workspace) | ||
| { | ||
| WaitForProjectSystem(timeout); |
Member
There was a problem hiding this comment.
@sharwell Is there a reason this code isn't in the implementation of GetWaitingService? Because don't we have other clients (DDRITs?) calling into that?
Contributor
Author
There was a problem hiding this comment.
The waiting service doesn't have visibility to the layers where the operation progress APIs are.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves flakiness problems in several tests, including:
VerifySyntaxErrorSquigglesVerifySemanticErrorSquigglesErrorLevelWarningErrorsDuringMethodBodyEditing