Merge master to features/param-nullchecking#36231
Merged
2 commits merged intofeatures/param-nullcheckingfrom Jun 7, 2019
Merged
Merge master to features/param-nullchecking#362312 commits merged intofeatures/param-nullcheckingfrom
2 commits merged intofeatures/param-nullcheckingfrom
Conversation
this particular code path can take a long time if metadata reference hasn't created its symbols yet. this can get really bad if we try to show code lens for something like IDispose.Dipose and it tries to create all metdata references in the solution. since it is not cancellable, just passing by a Dipose method can cause this to occupy CPU 100% for several seconds and there is no way to make it go away. now we pass in cancellation token so that we can bail out sooner.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from master into features/param-nullchecking.
(created from a manual run of the PR generation tool)
git fetch --all git checkout merges/master-to-features/param-nullchecking git reset --hard upstream/features/param-nullchecking git merge upstream/master # Fix merge conflicts git commit git push upstream merges/master-to-features/param-nullchecking --forceOnce all conflicts are resolved and all the tests pass, you are free to merge the pull request.