Skip to content

filter tests for async completion#36200

Merged
ivanbasov merged 3 commits intodotnet:masterfrom
ivanbasov:filters
Jun 11, 2019
Merged

filter tests for async completion#36200
ivanbasov merged 3 commits intodotnet:masterfrom
ivanbasov:filters

Conversation

@ivanbasov
Copy link
Copy Markdown
Contributor

@ivanbasov ivanbasov commented Jun 6, 2019

Fixes #29110

@ivanbasov ivanbasov added Area-IDE Test Test failures in roslyn-CI IDE-IntelliSense Completion, Signature Help, Quick Info labels Jun 6, 2019
@ivanbasov ivanbasov added this to the 16.2.P3 milestone Jun 6, 2019
@ivanbasov ivanbasov requested a review from genlu June 6, 2019 02:19
@ivanbasov ivanbasov requested a review from a team as a code owner June 6, 2019 02:19
@ivanbasov
Copy link
Copy Markdown
Contributor Author

ivanbasov commented Jun 6, 2019

@AmadeusW , @genlu this is a draft implementation.
Tests fail now.
Actually, need a help from @AmadeusW to involve the presenter into the completion process. It seems that the broker gets Options from the presenter provider but then the presenter provider is called only by the test code. I expect that it should be called from GetOrCreate and then the presenter will be called for Open and Update

@jinujoseph jinujoseph modified the milestones: 16.2.P3, 16.2 Jun 9, 2019
@ivanbasov
Copy link
Copy Markdown
Contributor Author

ivanbasov commented Jun 10, 2019

@genlu please review
@AmadeusW thank you for your help! Tests seem to work

@genlu
Copy link
Copy Markdown
Member

genlu commented Jun 11, 2019

A test failed, seems to be related to this change.

@ivanbasov
Copy link
Copy Markdown
Contributor Author

ivanbasov commented Jun 11, 2019

A test failed, seems to be related to this change.

looking into it. thank you!

@ivanbasov ivanbasov merged commit cb80072 into dotnet:master Jun 11, 2019
@ivanbasov ivanbasov deleted the filters branch June 11, 2019 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@genlu genlu genlu approved these changes

Assignees

No one assigned

Labels

Area-IDE IDE-IntelliSense Completion, Signature Help, Quick Info Test Test failures in roslyn-CI

Projects

None yet

Milestone

16.2

Development

Successfully merging this pull request may close these issues.

enable Filters_EmptyList* tests [Editor should take over these test scenarios, but we also need test-time discoverability & editing of filter state]

3 participants

@ivanbasov @genlu @jinujoseph