Dont try and check tuple conversions in error cases:#36188
Merged
chsienki merged 2 commits intodotnet:masterfrom Jun 12, 2019
Merged
Dont try and check tuple conversions in error cases:#36188chsienki merged 2 commits intodotnet:masterfrom
chsienki merged 2 commits intodotnet:masterfrom
Conversation
- When checking an identity converison, also check for a bound tuple if the type isn't a tuple as we might have a bound tuple with an error type - When checking a tuple conversion, don't GenerateConversion in the error case as we don't have a target type to generate against - Update tests
Member
Author
|
@dotnet/roslyn-compiler for review please |
RikkiGibson
approved these changes
Jun 5, 2019
Member
Author
|
@dotnet/roslyn-compiler for a second review please. |
cston
approved these changes
Jun 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35157