mark NFW from OOP critical#36156
Merged
heejaechang merged 5 commits intodotnet:masterfrom Jun 5, 2019
Merged
Conversation
currently, whenever OOP throws an exception, we show infobar saying "restart VS". whenever that happens, we report NFW. now those NFW will be marked as critical and we will stop reporting NFW after that in VS. basically making critical NFW behavior same as fatal watson in VS. and management will treat critical NFW same as fatal watson. also, now we will show callstack like code fix exception when info bar is shown
Contributor
Author
|
@ivanbasov @jinujoseph can you take a look. as we discussed. |
ivanbasov
reviewed
Jun 4, 2019
| /// </summary> | ||
| /// <param name="exception">Exception that triggered this non-fatal error</param> | ||
| public static void Report(Exception exception) | ||
| public static void Report(Exception exception, bool critical = false) |
Contributor
There was a problem hiding this comment.
bool critical = false [](start = 55, length = 21)
maybe enum is better
Contributor
Author
There was a problem hiding this comment.
@ivanbasov do you want enum with every thing? or just Critical and None?
Contributor
There was a problem hiding this comment.
I think that we may want the enum on our side to differ from the enum on the Telemetry side. So, we should define the enum for our purposes. Currently, it should contain Critical and None only.
Contributor
Author
There was a problem hiding this comment.
alright. will do!
ivanbasov
reviewed
Jun 4, 2019
jinujoseph
approved these changes
Jun 4, 2019
… (code fix) show remote exception in callstack view.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently, whenever OOP throws an exception, we show infobar saying "restart VS". whenever that happens, we report NFW. now those NFW will be marked as critical and we will stop reporting NFW after that in VS.
basically making critical NFW behavior same as fatal watson in VS. and management will treat critical NFW same as fatal watson.
also, now we will show callstack like code fix exception when info bar is shown