ExternalErrorDiagnosticUpdateSource and TableItem refactoring by tmat · Pull Request #36139 · dotnet/roslyn

tmat · 2019-06-03T23:26:34Z

Removes dependency on VS types from ExternalErrorDiagnosticUpdateSource
Simplifies DiagnosticData consturctors.

tmat · 2019-06-03T23:26:42Z

heejaechang · 2019-06-07T04:02:52Z

src/VisualStudio/Core/Def/Implementation/TaskList/ExternalErrorDiagnosticUpdateSource.cs

-                return;
-            }
+            // build just started, create the state and fire build in progress event.
+            // build just started, create the state and fire build in progress event.


heejaechang

nice!

sharwell · 2019-06-07T19:21:19Z

Integration test failure is a true failure:

Event Time (UTC): 6/7/2019 6:30:54 PM
Event ID: 1025
Data: Application: devenv.exe
Framework Version: v4.0.30319
Description: The application requested process termination through System.Environment.FailFast(string message).
Message: System.Exception
Stack:
   at System.Environment.FailFast(System.String, System.Exception)
   at Microsoft.CodeAnalysis.FailFast.OnFatalException(System.Exception)
   at Microsoft.CodeAnalysis.ErrorReporting.FatalError.Report(System.Exception, System.Action`1<System.Exception>)
   at Microsoft.CodeAnalysis.ErrorReporting.FatalError.Report(System.Exception)
   at Microsoft.VisualStudio.IntegrationTest.Setup.IntegrationTestTraceListener.Exit(System.String)
   at Microsoft.VisualStudio.IntegrationTest.Setup.IntegrationTestTraceListener.Fail(System.String, System.String)
   at System.Diagnostics.TraceListener.Fail(System.String)
   at System.Diagnostics.TraceInternal.Fail(System.String)
   at System.Diagnostics.Debug.Assert(Boolean)
   at Microsoft.VisualStudio.LanguageServices.Implementation.TaskList.ProjectExternalErrorReporter..ctor(Microsoft.CodeAnalysis.ProjectId, System.String, Microsoft.VisualStudio.LanguageServices.VisualStudioWorkspace, Microsoft.VisualStudio.LanguageServices.Implementation.TaskList.ExternalErrorDiagnosticUpdateSource)
   at Microsoft.VisualStudio.LanguageServices.Implementation.ProjectSystem.CPS.CPSProject+<>c__DisplayClass42_0.<.ctor>b__0()
   at System.Lazy`1[[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].CreateValue()
   at System.Lazy`1[[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].LazyInitValue()
   at System.Lazy`1[[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].get_Value()
   at Microsoft.VisualStudio.LanguageServices.Implementation.ProjectSystem.CPS.CPSProject.ReportError2(System.String, System.String, Microsoft.VisualStudio.Shell.Interop.VSTASKPRIORITY, Int32, Int32, Int32, Int32, System.String)
   at Microsoft.VisualStudio.ProjectSystem.VS.Build.LanguageServiceErrorListProvider+<>c__DisplayClass6_0.<AddMessageCoreAsync>b__0(Microsoft.VisualStudio.ProjectSystem.LanguageServices.IWorkspaceProjectContextAccessor)
   at Microsoft.VisualStudio.ProjectSystem.LanguageServices.WorkspaceProjectContextHost+WorkspaceProjectContextHostInstance+<>c__DisplayClass17_0`1[[System.Boolean, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].<OpenContextForWriteAsync>b__0(System.Threading.CancellationToken)
   at Microsoft.VisualStudio.ProjectSystem.OnceInitializedOnceDisposedUnderLockAsync+<>c__DisplayClass6_2`1+<<ExecuteUnderLockCoreAsync>b__0>d[[System.Boolean, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].MoveNext()
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start[[Microsoft.VisualStudio.ProjectSystem.OnceInitializedOnceDisposedUnderLockAsync+<>c__DisplayClass6_2`1+<<ExecuteUnderLockCoreAsync>b__0>d[[System.Boolean, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]], Microsoft.VisualStudio.ProjectSystem.Managed, Version=3.1.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35]](<<ExecuteUnderLockCoreAsync>b__0>d<Boolean> ByRef)
   at Microsoft.VisualStudio.ProjectSystem.OnceInitializedOnceDisposedUnderLockAsync+<>c__DisplayClass6_2`1[[System.Boolean, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].<ExecuteUnderLockCoreAsync>b__0()
   at Microsoft.VisualStudio.Threading.ReentrantSemaphore+StackSemaphore+<>c__DisplayClass3_0+<<ExecuteAsync>b__0>d.MoveNext()
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start[[Microsoft.VisualStudio.Threading.ReentrantSemaphore+StackSemaphore+<>c__DisplayClass3_0+<<ExecuteAsync>b__0>d, Microsoft.VisualStudio.Threading, Version=16.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]](<<ExecuteAsync>b__0>d ByRef)
   at Microsoft.VisualStudio.Threading.ReentrantSemaphore+StackSemaphore+<>c__DisplayClass3_0.<ExecuteAsync>b__0()
   at Microsoft.VisualStudio.Threading.JoinableTaskFactory.ExecuteJob[[Microsoft.VisualStudio.Threading.EmptyStruct, Microsoft.VisualStudio.Threading, Version=16.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]](System.Func`1<System.Threading.Tasks.Task>, Microsoft.VisualStudio.Threading.JoinableTask)
   at Microsoft.VisualStudio.Threading.ReentrantSemaphore.ExecuteCoreAsync(System.Func`1<System.Threading.Tasks.Task>)
   at Microsoft.VisualStudio.Threading.ReentrantSemaphore+StackSemaphore+<ExecuteAsync>d__3.MoveNext()
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start[[Microsoft.VisualStudio.Threading.ReentrantSemaphore+StackSemaphore+<ExecuteAsync>d__3, Microsoft.VisualStudio.Threading, Version=16.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]](<ExecuteAsync>d__3 ByRef)
   at Microsoft.VisualStudio.Threading.ReentrantSemaphore+StackSemaphore.ExecuteAsync(System.Func`1<System.Threading.Tasks.Task>, System.Threading.CancellationToken)
   at Microsoft.VisualStudio.ProjectSystem.OnceInitializedOnceDisposedUnderLockAsync+<ExecuteUnderLockCoreAsync>d__6`1[[System.Boolean, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].MoveNext()
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1[[System.Boolean, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].Start[[Microsoft.VisualStudio.ProjectSystem.OnceInitializedOnceDisposedUnderLockAsync+<ExecuteUnderLockCoreAsync>d__6`1[[System.Boolean, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]], Microsoft.VisualStudio.ProjectSystem.Managed, Version=3.1.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35]](<ExecuteUnderLockCoreAsync>d__6`1<Boolean> ByRef)
   at Microsoft.VisualStudio.ProjectSystem.OnceInitializedOnceDisposedUnderLockAsync.ExecuteUnderLockCoreAsync[[System.Boolean, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]](System.Func`2<System.Threading.CancellationToken,System.Threading.Tasks.Task`1<Boolean>>, System.Threading.CancellationToken)
   at Microsoft.VisualStudio.ProjectSystem.LanguageServices.WorkspaceProjectContextHost+WorkspaceProjectContextHostInstance+<OpenContextForWriteAsync>d__17`1[[System.Boolean, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].MoveNext()
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1[[System.Boolean, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].Start[[Microsoft.VisualStudio.ProjectSystem.LanguageServices.WorkspaceProjectContextHost+WorkspaceProjectContextHostInstance+<OpenContextForWriteAsync>d__17`1[[System.Boolean, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]], Microsoft.VisualStudio.ProjectSystem.Managed, Version=3.1.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35]](<OpenContextForWriteAsync>d__17`1<Boolean> ByRef)
   at Microsoft.VisualStudio.ProjectSystem.LanguageServices.WorkspaceProjectContextHost+WorkspaceProjectContextHostInstance.OpenContextForWriteAsync[[System.Boolean, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]](System.Func`2<Microsoft.VisualStudio.ProjectSystem.LanguageServices.IWorkspaceProjectContextAccessor,System.Threading.Tasks.Task`1<Boolean>>)
   at Microsoft.VisualStudio.ProjectSystem.LanguageServices.WorkspaceProjectContextHost+<OpenContextForWriteAsync>d__13`1[[System.Boolean, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].MoveNext()
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1[[System.Boolean, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].Start[[Microsoft.VisualStudio.ProjectSystem.LanguageServices.WorkspaceProjectContextHost+<OpenContextForWriteAsync>d__13`1[[System.Boolean, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]], Microsoft.VisualStudio.ProjectSystem.Managed, Version=3.1.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35]](<OpenContextForWriteAsync>d__13`1<Boolean> ByRef)
   at Microsoft.VisualStudio.ProjectSystem.LanguageServices.WorkspaceProjectContextHost.OpenContextForWriteAsync[[System.Boolean, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]](System.Func`2<Microsoft.VisualStudio.ProjectSystem.LanguageServices.IWorkspaceProjectContextAccessor,System.Threading.Tasks.Task`1<Boolean>>)
   at Microsoft.VisualStudio.ProjectSystem.LanguageServices.ActiveWorkspaceProjectContextHost+<OpenContextForWriteAsync>d__5`1[[System.Boolean, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].MoveNext()
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1[[System.Boolean, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].Start[[Microsoft.VisualStudio.ProjectSystem.LanguageServices.ActiveWorkspaceProjectContextHost+<OpenContextForWriteAsync>d__5`1[[System.Boolean, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]], Microsoft.VisualStudio.ProjectSystem.Managed, Version=3.1.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35]](<OpenContextForWriteAsync>d__5`1<Boolean> ByRef)
   at Microsoft.VisualStudio.ProjectSystem.LanguageServices.ActiveWorkspaceProjectContextHost.OpenContextForWriteAsync[[System.Boolean, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]](System.Func`2<Microsoft.VisualStudio.ProjectSystem.LanguageServices.IWorkspaceProjectContextAccessor,System.Threading.Tasks.Task`1<Boolean>>)
   at Microsoft.VisualStudio.ProjectSystem.VS.Build.LanguageServiceErrorListProvider+<AddMessageCoreAsync>d__6.MoveNext()
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1[[Microsoft.VisualStudio.ProjectSystem.VS.Build.AddMessageResult, Microsoft.VisualStudio.ProjectSystem.VS, Version=16.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]].Start[[Microsoft.VisualStudio.ProjectSystem.VS.Build.LanguageServiceErrorListProvider+<AddMessageCoreAsync>d__6, Microsoft.VisualStudio.ProjectSystem.Managed.VS, Version=3.1.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35]](<AddMessageCoreAsync>d__6 ByRef)
   at Microsoft.VisualStudio.ProjectSystem.VS.Build.LanguageServiceErrorListProvider.AddMessageCoreAsync(Microsoft.VisualStudio.ProjectSystem.VS.Build.TargetGeneratedError)
   at Microsoft.VisualStudio.ProjectSystem.VS.Build.LanguageServiceErrorListProvider.AddMessageAsync(Microsoft.VisualStudio.ProjectSystem.VS.Build.TargetGeneratedError)
   at Microsoft.VisualStudio.ProjectSystem.VS.Implementation.Build.VsProjectBuildErrorListPublishService+<AddMessagesAsync>d__32.MoveNext()
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start[[Microsoft.VisualStudio.ProjectSystem.VS.Implementation.Build.VsProjectBuildErrorListPublishService+<AddMessagesAsync>d__32, Microsoft.VisualStudio.ProjectSystem.VS.Implementation, Version=16.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]](<AddMessagesAsync>d__32 ByRef)
   at Microsoft.VisualStudio.ProjectSystem.VS.Implementation.Build.VsProjectBuildErrorListPublishService.AddMessagesAsync(System.String, System.Collections.Generic.IEnumerable`1<Microsoft.VisualStudio.ProjectSystem.Build.ProjectBuildMessage>)
   at Microsoft.VisualStudio.ProjectSystem.VS.Implementation.Build.VsProjectBuildErrorListPublishService+<ProcessQueueAsync>d__31.MoveNext()
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1[[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].Start[[Microsoft.VisualStudio.ProjectSystem.VS.Implementation.Build.VsProjectBuildErrorListPublishService+<ProcessQueueAsync>d__31, Microsoft.VisualStudio.ProjectSystem.VS.Implementation, Version=16.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]](<ProcessQueueAsync>d__31 ByRef)
   at Microsoft.VisualStudio.ProjectSystem.VS.Implementation.Build.VsProjectBuildErrorListPublishService.ProcessQueueAsync(Microsoft.VisualStudio.ProjectSystem.IProjectVersionedValue`1<Microsoft.VisualStudio.ProjectSystem.Build.ProjectBuildMessages>)
   at Microsoft.VisualStudio.ProjectSystem.VS.Implementation.Build.VsProjectBuildErrorListPublishService.<Initialize>b__29_0(Microsoft.VisualStudio.ProjectSystem.IProjectVersionedValue`1<Microsoft.VisualStudio.ProjectSystem.Build.ProjectBuildMessages>)
   at Microsoft.VisualStudio.ProjectSystem.TransformBlockSlim`2+TransformBlockSlimAsync+<ProcessInputAsync>d__3[[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089],[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].MoveNext()
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start[[Microsoft.VisualStudio.ProjectSystem.TransformBlockSlim`2+TransformBlockSlimAsync+<ProcessInputAsync>d__3[[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089],[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]], Microsoft.VisualStudio.ProjectSystem, Version=16.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]](<ProcessInputAsync>d__3<System.__Canon,System.__Canon> ByRef)
   at Microsoft.VisualStudio.ProjectSystem.TransformBlockSlim`2+TransformBlockSlimAsync[[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089],[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].ProcessInputAsync(System.__Canon)
   at Microsoft.VisualStudio.ProjectSystem.DataReceivingBlockSlim`1+<ProcessInputQueueAsync>d__5[[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].MoveNext()
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start[[Microsoft.VisualStudio.ProjectSystem.DataReceivingBlockSlim`1+<ProcessInputQueueAsync>d__5[[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]], Microsoft.VisualStudio.ProjectSystem, Version=16.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]](<ProcessInputQueueAsync>d__5<System.__Canon> ByRef)
   at Microsoft.VisualStudio.ProjectSystem.DataReceivingBlockSlim`1[[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].ProcessInputQueueAsync(InputDataBuffer<System.__Canon>)
   at Microsoft.VisualStudio.ProjectSystem.DataReceivingBlockSlim`1+<>c[[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].<System.Threading.Tasks.Dataflow.ITargetBlock<TInput>.OfferMessage>b__2_0(System.Object)
   at System.Threading.Tasks.Task`1[[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].InnerInvoke()
   at System.Threading.Tasks.Task.Execute()
   at System.Threading.Tasks.Task.ExecutionContextCallback(System.Object)
   at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
   at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(System.Threading.Tasks.Task ByRef)
   at System.Threading.Tasks.Task.ExecuteEntry(Boolean)
   at System.Threading.Tasks.Task.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
   at System.Threading.ThreadPoolWorkQueue.Dispatch()
   at System.Threading._ThreadPoolWaitCallback.PerformWaitCallback()

tmat requested a review from a team as a code owner June 3, 2019 23:26

tmat added 8 commits June 6, 2019 16:42

Ctor refactoring

cff1565

Renames

08dc93e

Renames

bdeb905

Cleanup

d3a8cdf

ProjectExternalErrorReporter ctor

9b73269

Refactoring

94349af

Remove dependency on VS

eaf7280

Aggregation improvements

226c9e5

tmat force-pushed the DiagnosticDataRefactoring branch from 136bc17 to 226c9e5 Compare June 6, 2019 23:43

tmat requested a review from a team as a code owner June 6, 2019 23:43

tmat changed the title ~~ExternalErrorDiagnosticUpdateSource refactoring~~ ExternalErrorDiagnosticUpdateSource and TbaleItem refactoring Jun 6, 2019

Use ordinal comparer for project names

12f3ec1

jcouv added the Area-Compilers label Jun 7, 2019

Construct ProjectExternalErrorReporter lazily

5e91f6b

heejaechang reviewed Jun 7, 2019

View reviewed changes

heejaechang approved these changes Jun 7, 2019

View reviewed changes

tmat changed the title ~~ExternalErrorDiagnosticUpdateSource and TbaleItem refactoring~~ ExternalErrorDiagnosticUpdateSource and TableItem refactoring Jun 7, 2019

Fix off by one

ac4bd65

Fix issues

095f8f1

tmat merged commit 8a84f1b into dotnet:master Jun 7, 2019

tmat deleted the DiagnosticDataRefactoring branch June 7, 2019 22:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ExternalErrorDiagnosticUpdateSource and TableItem refactoring#36139

ExternalErrorDiagnosticUpdateSource and TableItem refactoring#36139
tmat merged 12 commits intodotnet:masterfrom
tmat:DiagnosticDataRefactoring

tmat commented Jun 3, 2019 •

edited

Loading

Uh oh!

tmat commented Jun 3, 2019

Uh oh!

heejaechang Jun 7, 2019

Uh oh!

heejaechang left a comment

Uh oh!

sharwell commented Jun 7, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

tmat commented Jun 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tmat commented Jun 3, 2019

Uh oh!

heejaechang Jun 7, 2019

Choose a reason for hiding this comment

Uh oh!

heejaechang left a comment

Choose a reason for hiding this comment

Uh oh!

sharwell commented Jun 7, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tmat commented Jun 3, 2019 •

edited

Loading