Remove NonNullTypesOn/Off helper methods#36105
Merged
cston merged 2 commits intodotnet:masterfrom Jun 4, 2019
Merged
Conversation
Contributor
Author
|
@dotnet/roslyn-compiler please review. |
jcouv
approved these changes
May 31, 2019
Member
jcouv
left a comment
There was a problem hiding this comment.
Test-only change. LGTM Thanks (iteration 1)
AlekseyTs
reviewed
May 31, 2019
Contributor
There was a problem hiding this comment.
protected static string NonNullTypesOff() [](start = 8, length = 41)
@cston Could you please hold on on merging this change. I am about to create a PR that will be affected by removal of these helpers.
jasonmalinowski
approved these changes
Jun 3, 2019
Member
jasonmalinowski
left a comment
There was a problem hiding this comment.
Signing off for the IDE code; this can go in or not go in at your convenience. New IDE tests going in are just explicitly writing #nullable enable so it's not going to impact us.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.