Skip to content

support retries in integration tests#36100

Merged
sharwell merged 9 commits intodotnet:masterfrom
ivanbasov:retry
Jun 5, 2019
Merged

support retries in integration tests#36100
sharwell merged 9 commits intodotnet:masterfrom
ivanbasov:retry

Conversation

@ivanbasov
Copy link
Copy Markdown
Contributor

@ivanbasov ivanbasov commented May 31, 2019

Resolves #36058

@ivanbasov ivanbasov added the PR For Personal Review Only The PR doesn’t require anyone other than the developer to review it. label May 31, 2019
@ivanbasov ivanbasov requested a review from sharwell May 31, 2019 22:14
@ivanbasov ivanbasov requested review from a team as code owners May 31, 2019 22:14
@ivanbasov
Copy link
Copy Markdown
Contributor Author

Hi @sharwell ,
Let us start with this.

  1. I haven't actually executed this locally. Please let me know tips and tricks about local runs.
  2. I suppose this should be implemented some other way for WpfTheories or we should exclude them.
  3. I do not know if returning the time from the first attempt is enough or if we should send more to the message bus. See point 1.

@ivanbasov ivanbasov added Integration-Test Test failures in roslyn-integration-CI Area-Infrastructure labels May 31, 2019
@JoeRobich
Copy link
Copy Markdown
Member

Just a thought, but I suggested once that we create a separate leg for integration tests that we considered flaky. That way they still ran and we could monitor progress on moving them to the "stable" leg. I think I would prefer a solution more in that vain than simply rerunning failed tests.

@sharwell
Copy link
Copy Markdown
Contributor

sharwell commented Jun 1, 2019

@JoeRobich we're going to run some experiments in this branch and come back with clear data before attempting to make a decision.

Edit: I'll keep a running list of our experimental results here. Items marked "Pass with retry" are cases that would have failed without this pull request, but instead passed.

Iteration Result
0 Pass (4)
1 Pass (3), Pass with retry (1)
2 Pass (3), Pass with retry (1)
3 Pass (1), Pass with retry (1), Fail (2)
4 Pass (3), Pass with retry (1)
5 Pass (4)
--- ---
Total Pass (18), Pass with retry (4), In Progress (0), Fail (2)

Total completed legs in the experiment: 24
Total pass rate for legs in the experiment: 92%
Pass rate without the retry feature: 75%

One of the two failures that occurred with retry will be resolved by #36190.

@sharwell sharwell removed the PR For Personal Review Only The PR doesn’t require anyone other than the developer to review it. label Jun 5, 2019
@sharwell
Copy link
Copy Markdown
Contributor

sharwell commented Jun 5, 2019

This LGTM, just waiting on @jaredpar to approve expanding the experiment by merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure Integration-Test Test failures in roslyn-integration-CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto-retry failed integration tests

4 participants