Skip to content

Avoid renaming methods that don't change return type#36054

Merged
sharwell merged 1 commit intodotnet:masterfrom
sharwell:avoid-rename
May 31, 2019
Merged

Avoid renaming methods that don't change return type#36054
sharwell merged 1 commit intodotnet:masterfrom
sharwell:avoid-rename

Conversation

@sharwell
Copy link
Copy Markdown
Contributor

Fixes #33082

@sharwell sharwell requested a review from a team as a code owner May 30, 2019 02:39
Copy link
Copy Markdown
Contributor

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve
Submit feedback approving these changes.

Copy link
Copy Markdown
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinujoseph jinujoseph added this to the 16.2.P3 milestone May 31, 2019
@sharwell sharwell merged commit e516521 into dotnet:master May 31, 2019
@sharwell sharwell deleted the avoid-rename branch May 31, 2019 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'Make method async' breaks overridden methods

4 participants