Merged
Conversation
Contributor
Author
|
@jaredpar, @AlekseyTs, please review. cc @dotnet/roslyn-compiler |
Contributor
AlekseyTs
reviewed
May 29, 2019
| public static ImmutableArray<MetadataReference> Mscorlib461ExtendedReferences => ImmutableArray.Create<MetadataReference>(Net461.mscorlibRef, Net461.SystemRef, Net461.SystemCoreRef, Net461.SystemValueTupleRef, Net461.SystemRuntimeRef, Net461.netstandardRef); | ||
| public static ImmutableArray<MetadataReference> NetStandard20References => ImmutableArray.Create<MetadataReference>(NetStandard20.NetStandard, NetStandard20.MscorlibRef, NetStandard20.SystemRuntimeRef, NetStandard20.SystemCoreRef, NetStandard20.SystemDynamicRuntimeRef); | ||
| public static ImmutableArray<MetadataReference> NetStandard30References => ImmutableArray.Create<MetadataReference>(NetStandard30.NetStandard, NetStandard30.MscorlibRef, NetStandard30.SystemRuntimeRef, NetStandard30.SystemCoreRef, NetStandard30.SystemDynamicRuntimeRef, NetStandard30.SystemConsoleRef); | ||
| public static ImmutableArray<MetadataReference> NetStandard30References => ImmutableArray.Create<MetadataReference>(NetCoreApp30.NetStandard, NetCoreApp30.MscorlibRef, NetCoreApp30.SystemRuntimeRef, NetCoreApp30.SystemCoreRef, NetCoreApp30.SystemDynamicRuntimeRef, NetCoreApp30.SystemConsoleRef); |
Contributor
There was a problem hiding this comment.
NetStandard30References [](start = 56, length = 23)
We probably should rename this to NetCoreApp30References #Closed
Contributor
|
It looks like CI jobs are failing. Did we publish a new Nuget package for the resources? #Closed |
Contributor
|
Done with review pass (iteration 1) #Closed |
AlekseyTs
approved these changes
May 31, 2019
Contributor
AlekseyTs
left a comment
There was a problem hiding this comment.
LGTM (iteration 3), assuming CI is passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.