Skip to content

Update EditorFeatures.WPF dependencies#35923

Merged
JoeRobich merged 5 commits intodotnet:masterfrom
JoeRobich:fix-editorfeatures.wpf-dependencies
Jun 4, 2019
Merged

Update EditorFeatures.WPF dependencies#35923
JoeRobich merged 5 commits intodotnet:masterfrom
JoeRobich:fix-editorfeatures.wpf-dependencies

Conversation

@JoeRobich
Copy link
Copy Markdown
Member

Fixes #35897

@JoeRobich
Copy link
Copy Markdown
Member Author

@tmat Please take a look

@tmat
Copy link
Copy Markdown
Member

tmat commented May 23, 2019

I think we also need to update MicrosoftVisualStudioInteractiveWindowVersion to 2.8.0

@JoeRobich
Copy link
Copy Markdown
Member Author

@tmat Good catch. Updated.

@tmat
Copy link
Copy Markdown
Member

tmat commented May 30, 2019

I think we might need to add some package references to resolve the ambiguities :(.

@JoeRobich JoeRobich requested a review from a team as a code owner May 31, 2019 16:31
@JoeRobich
Copy link
Copy Markdown
Member Author

@tmat Updated package references.

@JoeRobich
Copy link
Copy Markdown
Member Author

@tmat I think I got all the references added. Please take another look.

Copy link
Copy Markdown
Member

@tmat tmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@JoeRobich JoeRobich merged commit e211e50 into dotnet:master Jun 4, 2019
@JoeRobich JoeRobich deleted the fix-editorfeatures.wpf-dependencies branch February 7, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Microsoft.CodeAnalysis.EditorFeatures.Wpf NuGet package needs to declare a dependency on Microsoft.VisualStudio.InteractiveWindow

2 participants