Skip to content

Revert "Make compilation outputs available via a workspace service (#34809)"#35642

Merged
dpoeschl merged 1 commit intodotnet:masterfrom
dpoeschl:RevertTomasChangeInMaster
May 10, 2019
Merged

Revert "Make compilation outputs available via a workspace service (#34809)"#35642
dpoeschl merged 1 commit intodotnet:masterfrom
dpoeschl:RevertTomasChangeInMaster

Conversation

@dpoeschl
Copy link
Contributor

@dpoeschl dpoeschl commented May 10, 2019

This reverts commit 3bdbd56.

The original PR caused failures in VS tests which are preventing us from making insertions, so we're rolling back for now.

@dpoeschl dpoeschl requested review from a team as code owners May 10, 2019 20:50
@dpoeschl
Copy link
Contributor Author

Tag for approval @jasonmalinowski @tmat

Copy link
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off in that this appears to be a revert of Tomas's changes into master. I have not reviewed the exact diff so if it was anything but a straight 'git revert' then this may require extra looking.

@dpoeschl dpoeschl merged commit cb056d8 into dotnet:master May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants