Use the hosted pool for integration tests#35603
Conversation
5ab8efa to
9570caf
Compare
06d74a6 to
cee03f0
Compare
There was a problem hiding this comment.
It shouldn't be needed with 854772f, but I got a failure in CI anyway. I'm planning to submit a follow-up PR to revert this change and it will merge as soon as we can get it to pass, which at the latest will be whenever the change that removed this property ships in a preview image.
When the failure occurs, csproj projects fail to load correctly in integration test runs.
There was a problem hiding this comment.
➡️ Submitted #35725 to revert this change as a follow-up.
azure-pipelines-integration.yml
Outdated
There was a problem hiding this comment.
Don't think we should be craeting a log2 directory. That complicates our infrastructure here. Should be focusing on a single log dir.
There was a problem hiding this comment.
This restored the ability to collect xunit.console.x86 logs following a hang. Test hangs cannot be diagnosed without this file.
I'm happy to remove this separation once we resolve the underlying issue, but I believe the inability to diagnose test failures is the more acute issue.
There was a problem hiding this comment.
➡️ Submitted #35726 to revert this after the Azure Pipelines artifact investigation is completed.
There was a problem hiding this comment.
What limitation in azure are you referring to? Our investigation with them revealed that it's almost certainly our problem, not there's.
There was a problem hiding this comment.
Before this change, only 1 of 8 hung builds included the dump file (0/1 in 20190514.12, 0/3 in 20190509.23, and 1/4 in 20190509.7). After this change, both hung builds in 20190514.34 included this file and I was able to immediately correct the cause.
There was a problem hiding this comment.
That just continues to confirm the problem is on our end, not Azure's. If this is an Azure bug then we need to have data to give them about it. Specifically, as they requested in the email, list the contents of the directory showing we wrote the file and they didn't upload it.
| _description = description; | ||
| _title = title ?? throw new ArgumentNullException(nameof(title)); | ||
| _helpString = helpString ?? throw new ArgumentNullException(nameof(helpString)); | ||
| _description = description ?? throw new ArgumentNullException(nameof(description)); |
No description provided.