Update to Roslyn.Diagnostics.Analyzers 2.9.3-beta1.19273.2+0e597a9e#35439
Closed
sharwell wants to merge 18 commits intodotnet:masterfrom
Closed
Update to Roslyn.Diagnostics.Analyzers 2.9.3-beta1.19273.2+0e597a9e#35439sharwell wants to merge 18 commits intodotnet:masterfrom
sharwell wants to merge 18 commits intodotnet:masterfrom
Conversation
d21a590 to
3f073e7
Compare
This was referenced May 3, 2019
This comment has been minimized.
This comment has been minimized.
This was referenced May 21, 2019
Merged
3f073e7 to
931a6cd
Compare
…ld have ImportingConstructor)
…ctor should be [Obsolete])
…onstructor should be [Obsolete])
Hidden severity allows the code fix to continue working, but disables visible diagnostics related to this analyzer.
931a6cd to
32f70a6
Compare
mavasani
reviewed
May 23, 2019
| *REMOVED*Shared Microsoft.CodeAnalysis.VisualBasic.VisualBasicSyntaxTree.ParseText(text As String, options As Microsoft.CodeAnalysis.VisualBasic.VisualBasicParseOptions = Nothing, path As String = "", encoding As System.Text.Encoding = Nothing, cancellationToken As System.Threading.CancellationToken = Nothing) -> Microsoft.CodeAnalysis.SyntaxTree | ||
| *REMOVED*Shared Microsoft.CodeAnalysis.VisualBasic.SyntaxFactory.ParseSyntaxTree(text As Microsoft.CodeAnalysis.Text.SourceText, options As Microsoft.CodeAnalysis.ParseOptions = Nothing, path As String = "", cancellationToken As System.Threading.CancellationToken = Nothing) -> Microsoft.CodeAnalysis.SyntaxTree | ||
| *REMOVED*Shared Microsoft.CodeAnalysis.VisualBasic.SyntaxFactory.ParseSyntaxTree(text As String, options As Microsoft.CodeAnalysis.ParseOptions = Nothing, path As String = "", encoding As System.Text.Encoding = Nothing, cancellationToken As System.Threading.CancellationToken = Nothing) -> Microsoft.CodeAnalysis.SyntaxTree | ||
| Microsoft.CodeAnalysis.VisualBasic.AggregateClauseSymbolInfo.Select1() -> Microsoft.CodeAnalysis.SymbolInfo |
Contributor
There was a problem hiding this comment.
I presume these are all coming from @CyrusNajmabadi's fix to the public API analyzer to correctly track auto-properties in VB? Should these entries be moved to Shipped API txt?
Contributor
Author
There was a problem hiding this comment.
Yes, that's the source of the difference. Can you verify that all relevant additions were already shipped?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review is only possible commit-by-commit.
Closes #35941