Allow the simplification of using directives where the global alias is specified#34964
Merged
sharwell merged 4 commits intodotnet:masterfrom Apr 19, 2019
Merged
Allow the simplification of using directives where the global alias is specified#34964sharwell merged 4 commits intodotnet:masterfrom
sharwell merged 4 commits intodotnet:masterfrom
Conversation
heejaechang
reviewed
Apr 13, 2019
src/Workspaces/CSharp/Portable/Extensions/ExpressionSyntaxExtensions.cs
Outdated
Show resolved
Hide resolved
sharwell
approved these changes
Apr 15, 2019
src/Workspaces/CSharp/Portable/Extensions/ExpressionSyntaxExtensions.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Apr 15, 2019
Contributor
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
LGTM. Thanks for tracking down my concerns!4
30b391d to
3077af7
Compare
Member
Author
|
Rebased on dev16.1-preview2 |
Member
Author
|
@vatsalyaagrawal for approval |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is being created to simplify #30760
UsingDirectives that are expanded using
Simplifier.Expandare given theglobal::alias which is not removed when callingSimplifier.ReduceAsync.