Add IVsRefactorNotify changes to MoveToNamespace refactorings#34915
Merged
ryzngard merged 4 commits intodotnet:masterfrom Apr 17, 2019
Merged
Add IVsRefactorNotify changes to MoveToNamespace refactorings#34915ryzngard merged 4 commits intodotnet:masterfrom
ryzngard merged 4 commits intodotnet:masterfrom
Conversation
Member
|
Just curious, what is |
Contributor
Author
|
@genlu It allows a hook for things like code generators (like WPF) to react to symbol name changes. The inline rename feature adds these as well, and we'll likely need to add for sync namespace |
JoeRobich
reviewed
Apr 11, 2019
src/Features/Core/Portable/MoveToNamespace/AbstractMoveToNamespaceCodeAction.cs
Outdated
Show resolved
Hide resolved
src/Features/Core/Portable/MoveToNamespace/AbstractMoveToNamespaceService.cs
Outdated
Show resolved
Hide resolved
src/Features/Core/Portable/MoveToNamespace/MoveToNamespaceResult.cs
Outdated
Show resolved
Hide resolved
src/Features/Core/Portable/MoveToNamespace/AbstractMoveToNamespaceCodeAction.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@jinujoseph @vatsalyaagrawal for approval |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If available, use the host service to provide IVsRefactorNotify changes of the symbols being changed so dependent frameworks
can handle the changes appropriately.
Adds unit tests that verify we have the correct code operations produced when we expect symbols to change.
Fixes #34685 for move type. Still needs to be done for sync to namespace I believe