Ensure synthesized BoundBaseReference always uses correct type.#34500
Merged
AlekseyTs merged 1 commit intodotnet:features/DefaultInterfaceImplementationfrom Mar 28, 2019
Conversation
99 tasks
Contributor
Author
|
@dotnet/roslyn-compiler Please review |
333fred
reviewed
Mar 27, 2019
| var compilation0 = CreateCompilation(source0, options: TestOptions.DebugExe, targetFramework: TargetFramework.NetStandardLatest); | ||
| compilation0.VerifyDiagnostics(); | ||
|
|
||
| var verifier = CompileAndVerify(compilation0, expectedOutput: !ExecutionConditionUtil.IsMonoOrCoreClr ? null : @"M1", verify: VerifyOnMonoOrCoreClr); |
Member
There was a problem hiding this comment.
!ExecutionConditionUtil.IsMonoOrCoreClr ? null : @"M1" [](start = 74, length = 54)
Consider inverting this conditional to make it simpler to read. #WontFix
Contributor
Author
There was a problem hiding this comment.
Consider inverting this conditional to make it simpler to read.
I find it much easier to have the string at the end, especially when it is multi-line.
Contributor
Author
|
@dotnet/roslyn-compiler Please review, need a second sign-off for a very small change |
1 similar comment
Contributor
Author
|
@dotnet/roslyn-compiler Please review, need a second sign-off for a very small change |
cston
approved these changes
Mar 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.