Do not qualify instance member access within a constructor initializer#34402
Merged
sharwell merged 8 commits intodotnet:masterfrom Jun 8, 2019
KGRWhite:32093fix
Merged
Do not qualify instance member access within a constructor initializer#34402sharwell merged 8 commits intodotnet:masterfrom KGRWhite:32093fix
sharwell merged 8 commits intodotnet:masterfrom
KGRWhite:32093fix
Conversation
sharwell
reviewed
Mar 25, 2019
src/Features/CSharp/Portable/QualifyMemberAccess/CSharpQualifyMemberAccessDiagnosticAnalyzer.cs
Outdated
Show resolved
Hide resolved
sharwell
reviewed
Mar 25, 2019
src/Features/CSharp/Portable/QualifyMemberAccess/CSharpQualifyMemberAccessDiagnosticAnalyzer.cs
Outdated
Show resolved
Hide resolved
…MemberAccessDiagnosticAnalyzer.cs Co-Authored-By: KGRWhite <kylewhite1986@gmail.com>
sharwell
approved these changes
Mar 25, 2019
src/EditorFeatures/CSharpTest/QualifyMemberAccess/QualifyMemberAccessTests.cs
Outdated
Show resolved
Hide resolved
src/EditorFeatures/CSharpTest/QualifyMemberAccess/QualifyMemberAccessTests.cs
Outdated
Show resolved
Hide resolved
src/EditorFeatures/CSharpTest/QualifyMemberAccess/QualifyMemberAccessTests.cs
Show resolved
Hide resolved
src/Features/CSharp/Portable/QualifyMemberAccess/CSharpQualifyMemberAccessDiagnosticAnalyzer.cs
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Mar 25, 2019
Contributor
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
LGTM. Though validating that VB is ok as well would be great!
…rAccessTests.cs Co-Authored-By: KGRWhite <kylewhite1986@gmail.com>
…rAccessTests.cs Co-Authored-By: KGRWhite <kylewhite1986@gmail.com>
…rAccessTests.cs Co-Authored-By: KGRWhite <kylewhite1986@gmail.com>
Contributor
|
@KGRWhite Thanks for updating this! I'm not sure why the build is failing so I will investigate and see about getting this merged 👍 |
sharwell
suggested changes
Mar 25, 2019
src/Features/CSharp/Portable/QualifyMemberAccess/CSharpQualifyMemberAccessDiagnosticAnalyzer.cs
Outdated
Show resolved
Hide resolved
…MemberAccessDiagnosticAnalyzer.cs Co-Authored-By: KGRWhite <kylewhite1986@gmail.com>
sharwell
approved these changes
Mar 26, 2019
Contributor
|
@KGRWhite thank you again 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32093