Closed
Conversation
The `MissingTypeKindBasisTypes` test is copied from `UseSiteErrorTests` and given verification succeeds there it's reasonable to expect that it would succeed here. However there are a few factors here that aren't obvious at a glance. The first is that not all of the compilations in `UseSiteErrorTests` are verifable. The `compilation1` is not verifiable in either suite, it's hard to miss because it's not tested. The reason why is that the corlib reference name is mincorlib, not mscorlib. PEVerify is hard coded to think the name of corlib will always be mscorlib. Hence any attempt to verify against a different name corlib will always fail. Well ... almost always. It fails only when it's used in the IL. For `compilation2` there is no direct reference to corlib, hence mincorlib doesn't appear in the IL and it passes verification. With NRT though we silently emit an attribute in the binary for nullable tracking and this does reference corlib (the attribute derives from `System.Attribute`) and hence verification fails. Adjusted the suite to make this expected. closes dotnet#30747
This changes our core compiler helpers to default verification off of the target framework and references. This should remove some confusion about verification in the test suites and make it more correct by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.