Offer completion for #nullable enable|disable#31171
Merged
jcouv merged 5 commits intodotnet:dev16.0-preview2from Nov 15, 2018
Merged
Offer completion for #nullable enable|disable#31171jcouv merged 5 commits intodotnet:dev16.0-preview2from
#nullable enable|disable#31171jcouv merged 5 commits intodotnet:dev16.0-preview2from
Conversation
3 tasks
src/EditorFeatures/CSharpTest2/Recommendations/DisableKeywordRecommenderTests.cs
Show resolved
Hide resolved
src/Features/CSharp/Portable/Completion/KeywordRecommenders/NullableKeywordRecommender.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Nov 14, 2018
Member
Author
|
Thanks! |
sharwell
approved these changes
Nov 14, 2018
src/EditorFeatures/CSharpTest2/Recommendations/NullableKeywordRecommenderTests.cs
Show resolved
Hide resolved
src/EditorFeatures/CSharpTest2/Recommendations/EnableKeywordRecommenderTests.cs
Show resolved
Hide resolved
52aed75 to
c20ff50
Compare
Member
Author
|
@jinujoseph for preview2 approval. Thanks |
AlekseyTs
approved these changes
Nov 15, 2018
Contributor
AlekseyTs
left a comment
There was a problem hiding this comment.
Code under Compilers LGTM (iteration 5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mostly an IDE fix, but also includes a minor fix to compiler APIs.
#nullable#nullable enable|disableAddresses part of #31130