'is' operator should not affect StateWhenFalse#30283
Merged
jcouv merged 1 commit intodotnet:features/NullableReferenceTypesfrom Oct 3, 2018
Merged
'is' operator should not affect StateWhenFalse#30283jcouv merged 1 commit intodotnet:features/NullableReferenceTypesfrom
jcouv merged 1 commit intodotnet:features/NullableReferenceTypesfrom
Conversation
Member
Author
|
@cston @333fred @AlekseyTs Tiny fix for the |
AlekseyTs
reviewed
Oct 3, 2018
| { | ||
| Split(); | ||
| this.StateWhenTrue[slot] = true; | ||
| this.StateWhenFalse[slot] = false; |
Contributor
There was a problem hiding this comment.
this.StateWhenFalse[slot] = false; [](start = 16, length = 34)
Should we still do this for is object case?
Member
Author
There was a problem hiding this comment.
Interesting. Feels like we could.
There's a whole class of such cases:
C x = null;
if (x is C) ...
Member
Author
There was a problem hiding this comment.
Filed #30297 as follow-up, since a possibly missing warning is less urgent than fixing a false alarm warning.
gafter
reviewed
Oct 3, 2018
| Split(); | ||
| this.StateWhenTrue[slot] = true; | ||
| this.StateWhenFalse[slot] = false; | ||
| } |
Member
There was a problem hiding this comment.
Please add open issues for refining the analysis for cases such as these.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29318