Skip to content

Merge master to features/embeddedJson#29687

Merged
10 commits merged intofeatures/embeddedJsonfrom
merges/master-to-features/embeddedJson
Sep 7, 2018
Merged

Merge master to features/embeddedJson#29687
10 commits merged intofeatures/embeddedJsonfrom
merges/master-to-features/embeddedJson

Conversation

@dotnet-bot
Copy link
Copy Markdown
Collaborator

This is an automatically generated pull request from master into features/embeddedJson.

git fetch --all
git checkout merges/master-to-features/embeddedJson
git reset --hard upstream/features/embeddedJson
git merge upstream/master
# Fix merge conflicts
git commit
git push merges/master-to-features/embeddedJson --force

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request.

Change the Mono helpers:

1. Properly don't run verification on Mono. Only Windows Desktop runs
verification at this time
1. Use the CoreClr ilasm utility instead of the Mono version. It has the
functionality we need for our unit tests.
Enable remaining VB tests on Linux CoreClr
Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit 4544ba1 into features/embeddedJson Sep 7, 2018
@ghost ghost deleted the merges/master-to-features/embeddedJson branch September 7, 2018 22:30
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants