Enable VB Semantic tests on CoreClr Linux#29570
Merged
jaredpar merged 4 commits intodotnet:masterfrom Aug 30, 2018
Merged
Conversation
Member
Author
|
CC @dotnet/roslyn-compiler for review |
cston
reviewed
Aug 29, 2018
| } | ||
| else | ||
| { | ||
| if (inputString.Contains("\r\n")) |
Contributor
There was a problem hiding this comment.
if check is not necessary. Consider removing else and replacing with return inputString.Replace("\r\n", "\n");.
Member
Author
There was a problem hiding this comment.
Will fix that up in the upcoming PR to enable Emit tests.
cston
approved these changes
Aug 29, 2018
Member
Author
|
retest ubuntu_16_debug_prtest please |
333fred
reviewed
Aug 30, 2018
| public static string NormalizeNewLines(XCData data) | ||
| { | ||
| if (!inputString.Contains("\r\n") && inputString.Contains("\n")) | ||
| if (ExecutionConditionUtil.IsWindows) |
Member
There was a problem hiding this comment.
Isn't this going to break any text that comes in with \r\n? We'll end up with \r\r\n.
Member
Author
There was a problem hiding this comment.
The XCData type is the input here and it can only have \n in the Value property. Hence this is safe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #29399