Fix issue where 'remove parens' would break code with ++/-- operators.#29457
Merged
jasonmalinowski merged 3 commits intodotnet:masterfrom Aug 30, 2018
Merged
Fix issue where 'remove parens' would break code with ++/-- operators.#29457jasonmalinowski merged 3 commits intodotnet:masterfrom
jasonmalinowski merged 3 commits intodotnet:masterfrom
Conversation
Contributor
Author
|
Tagging @jcouv @dotnet/roslyn-ide @jasonmalinowski |
9befe80 to
245b5d5
Compare
245b5d5 to
0408a1a
Compare
Contributor
Author
|
Tagging @jcouv @dotnet/roslyn-ide @jasonmalinowski |
Member
jasonmalinowski
left a comment
There was a problem hiding this comment.
@CyrusNajmabadi one question about some code and how it handles script mode. Might just need another test. Otherwise this looks good.
|
|
||
| // Have to be careful if we would remove parens and cause a + and a + to become a ++. | ||
| // (same with - as well). | ||
| var tokenBeforeParen = node.GetFirstToken().GetPreviousToken(); |
Member
There was a problem hiding this comment.
Does this have problems in script/interactive mode?
Contributor
Author
There was a problem hiding this comment.
Fortunately no. GetPreviousToken will simply return default(SyntaxToken). default(SyntaxToken) returns empty-string for .Text, and LastOrDefault will just return 0 in that case.
jasonmalinowski
approved these changes
Aug 30, 2018
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29454
Also fixes a related issue i found while looking into this area where we could break code of the form
x+(++y).