Skip to content

Restore the machinery for enabling language features by feature flags#29387

Merged
mavasani merged 2 commits intodotnet:features/compilerfrom
mavasani:Issue29291
Aug 21, 2018
Merged

Restore the machinery for enabling language features by feature flags#29387
mavasani merged 2 commits intodotnet:features/compilerfrom
mavasani:Issue29291

Conversation

@mavasani
Copy link
Copy Markdown
Contributor

Fixes #29291

@mavasani mavasani requested review from a team and gafter August 17, 2018 23:35
Copy link
Copy Markdown
Member

@gafter gafter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@gafter
Copy link
Copy Markdown
Member

gafter commented Aug 17, 2018

There appears to be a build error.

@mavasani
Copy link
Copy Markdown
Contributor Author

@dotnet-bot retest windows_release_vs-integration_prtest please

@mavasani
Copy link
Copy Markdown
Contributor Author

Ping @dotnet/roslyn-compiler for another review.

@mavasani
Copy link
Copy Markdown
Contributor Author

Ping @dotnet/roslyn-compiler for second review.

@mavasani
Copy link
Copy Markdown
Contributor Author

retest windows_release_vs-integration_prtest please

@mavasani
Copy link
Copy Markdown
Contributor Author

Integration test failure is unrelated to this change.

@mavasani mavasani merged commit db513b6 into dotnet:features/compiler Aug 21, 2018
@mavasani mavasani deleted the Issue29291 branch August 21, 2018 22:38
@gafter
Copy link
Copy Markdown
Member

gafter commented Aug 22, 2018

THANK YOU!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants